Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

feat(rome_rowan): cast and parent to help SyntaxNode and AstNode navigation #2601

Merged
merged 3 commits into from
May 23, 2022

Conversation

xunilrj
Copy link
Contributor

@xunilrj xunilrj commented May 20, 2022

this PR is about this discussion: #2586

I avoided the lifted parent method because is more unconventional.

@xunilrj xunilrj temporarily deployed to aws May 20, 2022 12:53 Inactive
@github-actions
Copy link

Parser conformance results on ubuntu-latest

js/262

Test result main count This PR count Difference
Total 45878 45878 0
Passed 44938 44938 0
Failed 940 940 0
Panics 0 0 0
Coverage 97.95% 97.95% 0.00%

jsx/babel

Test result main count This PR count Difference
Total 39 39 0
Passed 36 36 0
Failed 3 3 0
Panics 0 0 0
Coverage 92.31% 92.31% 0.00%

ts/babel

Test result main count This PR count Difference
Total 588 588 0
Passed 519 519 0
Failed 69 69 0
Panics 0 0 0
Coverage 88.27% 88.27% 0.00%

ts/microsoft

Test result main count This PR count Difference
Total 16257 16257 0
Passed 12391 12391 0
Failed 3866 3866 0
Panics 0 0 0
Coverage 76.22% 76.22% 0.00%

@github-actions
Copy link

github-actions bot commented May 20, 2022

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented May 20, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: b57738a
Status: ✅  Deploy successful!
Preview URL: https://80dbb4a9.tools-8rn.pages.dev

View logs

crates/rome_rowan/Cargo.toml Outdated Show resolved Hide resolved
crates/rome_rowan/src/ast/mod.rs Show resolved Hide resolved
crates/rome_rowan/Cargo.toml Outdated Show resolved Hide resolved
@MichaReiser
Copy link
Contributor

Any thoughts around a prelude that automatically imports this trait?

@xunilrj xunilrj temporarily deployed to aws May 23, 2022 09:08 Inactive
@xunilrj xunilrj temporarily deployed to aws May 23, 2022 09:09 Inactive
@xunilrj
Copy link
Contributor Author

xunilrj commented May 23, 2022

Any thoughts around a prelude that automatically imports this trait?

At the moment we are already publishing everything from the ast module.

@xunilrj xunilrj merged commit d50df88 into main May 23, 2022
@xunilrj xunilrj deleted the feature/cst-cast-and-parent branch May 23, 2022 09:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants