This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
fix(rome_formatter): dbg_write
API compatibility with write
#2708
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR ensures that the
buffer
argument ofdbg_write!
is compatible with thebuffer
argument ofwrite!
so that the two can be swapped without any changes to the debugged code.The current implementation hasn't been compatible because the
dbg_write!
macro called intoInspect::new
that expected a&mut Buffer
which requires the use of&mut buffer
if an implementation uses a localBuffer
variable.This PR changes the macro implementation to use
Buffer.inspect
instead that works for any mutableBuffer
.Test Plan
I changed the
dbg_write
macro test to pass inbuffer
without&mut
.