Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

feat(rome_js_analyze): useShorthandType #2745

Merged
merged 19 commits into from
Jun 27, 2022
Merged

feat(rome_js_analyze): useShorthandType #2745

merged 19 commits into from
Jun 27, 2022

Conversation

IWANABETHATGUY
Copy link
Contributor

Summary

  1. Resolved useShorthandArrayType #2744

Test Plan

  1. cargo test

@IWANABETHATGUY IWANABETHATGUY changed the title feat(rome_js_analyze): preferShortHandType feat(rome_js_analyze): useShortHandType Jun 20, 2022
@IWANABETHATGUY IWANABETHATGUY changed the title feat(rome_js_analyze): useShortHandType feat(rome_js_analyze): useShorthandType Jun 21, 2022
@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review June 21, 2022 10:04
@ematipico ematipico self-requested a review June 22, 2022 14:51
ematipico
ematipico suggested changes Jun 22, 2022
View reviewed changes
Copy link
Contributor

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is failing

@IWANABETHATGUY
Copy link
Contributor Author

CI is failing

Addressed

@IWANABETHATGUY
Copy link
Contributor Author

@ematipico , I think this pr is ready to merge.

@leops leops merged commit 58c297f into rome:main Jun 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ematipico ematipico ematipico approved these changes

@leops leops leops approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

useShorthandArrayType
3 participants
@IWANABETHATGUY @ematipico @leops