This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
refactor(formatter): Use slice to store content #2775
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR changes the
Content
type alias forFormatElement
fromBox<FormatElement>
toBox<[FormatElement]>
.The main motivation behind this is that
VecBuffer
always allocates a new vector even if only one element was written. Instead of discarding this vector and then boxing the element this PR usesvec.into_boxed_slice
that avoids the additional allocation.Dhat numbers:
Test Plan
This PR isn't adding any new functionality.
Performance