This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
refactor(rome_js_formatter): Remove Copy from JsFormatContext
#2779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the `Copy` from `JsFormatContext` to allow storing non-copyable data in the context. The idea is to store the extracted comments as an `Rc<Comments>` but this isn't possible today because `Rc` (nor `Comments`) implements `Copy`.
MichaReiser
commented
Jun 24, 2022
|
|
||
| /// Options of current instance of the formatter | ||
| pub options: JsFormatOptions, |
There was a problem hiding this comment.
I decided to inline this type as it only holds one field.
Deploying with
|
| Latest commit: |
106188d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ba0bdee5.tools-8rn.pages.dev |
| Branch Preview URL: | https://refactor-js-context-remove-c.tools-8rn.pages.dev |
leops
approved these changes
Jun 24, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove the
CopyfromJsFormatContextto allow storing non-copyable data in the context. The idea is to store the extracted comments as anRc<Comments>but this isn't possible today becauseRc(norComments) implementsCopy.Test Plan
The rust compiler is so kind to point me towards all places where we now need to call
clone(only in tests).