This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 664
feat(rome_js_analyze): noUnnecessaryContinue #2796
Merged
ematipico
merged 12 commits into
rome:main
from
IWANABETHATGUY:feat/no-unnecessary-continue
Jul 1, 2022
Merged
feat(rome_js_analyze): noUnnecessaryContinue #2796
ematipico
merged 12 commits into
rome:main
from
IWANABETHATGUY:feat/no-unnecessary-continue
Jul 1, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IWANABETHATGUY
changed the title
Feat/no unnecessary continue
feat(rome_js_analyze): noUnnecessaryContinue
Jun 29, 2022
leops
reviewed
Jun 30, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution. I can't help but wonder if this would be easier to implement by running the checks on the control flow graph instead of the syntax tree, but that's not ready at the moment
crates/rome_js_analyze/src/analyzers/no_unnecessary_continue.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/src/analyzers/no_unnecessary_continue.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/src/analyzers/no_unnecessary_continue.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/src/analyzers/no_unnecessary_continue.rs
Outdated
Show resolved
Hide resolved
crates/rome_js_analyze/src/analyzers/no_unnecessary_continue.rs
Outdated
Show resolved
Hide resolved
I would like to have a try after |
I have been addressed all issues, would you mind reviewing again? |
leops
approved these changes
Jul 1, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan