This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
feat(rome_js_analyze): noLabelVar #2838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IWANABETHATGUY
commented
Jul 6, 2022
IWANABETHATGUY
commented
Jul 6, 2022
| @@ -48,7 +48,7 @@ fn generate_module(name: &'static str, entries: &mut Vec<String>) -> Result<()> | |||
| let rule_name = format_ident!("{}", rule_name); | |||
|
|
|||
| rules.insert( | |||
| index, | |||
| index.min(rules.len()), | |||
There was a problem hiding this comment.
The index may be out of bounds of rules vector. Because index is the binary search result of entries, which length is always greater equal to the rules's. So we need to use index.min(rules.len() to avoid out of bounds insertion.
There was a problem hiding this comment.
Yes this is due to the entries vector now being shared between analyzers and semantic_analyzers, I have a proper fix for this ready as part of the refactor adding rule groups
leops
approved these changes
Jul 8, 2022
|
Don't merge for now, the current implementation is not efficient, I will optimize it. |
|
This could be merged once #2841 is merged. |
Done. |
NIce. |
ematipico
approved these changes
Jul 8, 2022
Co-authored-by: Emanuele Stoppa <my.burning@gmail.com>
Co-authored-by: Emanuele Stoppa <my.burning@gmail.com>
Co-authored-by: Emanuele Stoppa <my.burning@gmail.com>
ematipico
approved these changes
Jul 11, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan