This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
perf(rome_analyze): optimize code actions diff generation #2842
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The generation of code action diffs shows up a lot when profiling the analyzer, so I've optimized it a bit by making it skip over irrelevant subtrees. For
find_diff_range
this implies comparing the green nodes between the old and new version of the tree, so I've made thekey
method public onSyntaxNode
/SyntaxToken
/SyntaxElement
Test Plan
The snapshot tests for the analyzer still pass, as well as the unit tests for
find_diff_range
although I had to change the expected values since the function now compares the green nodes instead of the text content