Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

feat(rome_cli): add --max-diagnostics argument to rome check #2843

Merged
merged 4 commits into from
Jul 8, 2022
Merged

feat(rome_cli): add --max-diagnostics argument to rome check #2843

merged 4 commits into from
Jul 8, 2022

Conversation

ematipico
Copy link
Contributor

Summary

This PR adds a new argument to the command rome check called --max-diagnostics.

This should cap the number of diagnostics displayable by our CLI.

  • default number is 20
  • maximum number of printable diagnostics is 50 printable
  • if the number of diagnostics exceeds 50, a warning message is then printed

Test Plan

Added tests to verify the new changes

@ematipico ematipico temporarily deployed to aws July 7, 2022 16:45 Inactive
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jul 7, 2022 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 56a5376
Status: ✅  Deploy successful!
Preview URL: https://2662bb02.tools-8rn.pages.dev
Branch Preview URL: https://fature-max-diagnostics.tools-8rn.pages.dev

View logs

@ematipico ematipico temporarily deployed to aws July 7, 2022 16:48 Inactive
@ematipico ematipico requested review from leops and yassere July 7, 2022 16:48
@github-actions
Copy link

github-actions bot commented Jul 7, 2022 •
edited
Loading

Playground for commit 0e85f88

@ematipico ematipico temporarily deployed to aws July 7, 2022 16:50 Inactive
@ematipico ematipico temporarily deployed to aws July 8, 2022 07:07 Inactive
@ematipico ematipico requested a review from yassere July 8, 2022 07:10
@ematipico ematipico temporarily deployed to aws July 8, 2022 07:10 Inactive
@ematipico ematipico temporarily deployed to aws July 8, 2022 10:16 Inactive
@ematipico ematipico requested review from leops and yassere July 8, 2022 16:21
yassere
yassere approved these changes Jul 8, 2022
View reviewed changes
Copy link
Contributor

@yassere yassere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's worth revisiting in the future if we need a hard maximum for displayable diagnostics, but this seems fine for now.

@ematipico ematipico merged commit 8a030e4 into main Jul 8, 2022
@ematipico ematipico deleted the fature/max-diagnostics branch July 8, 2022 17:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@xunilrj xunilrj xunilrj approved these changes

@yassere yassere yassere approved these changes

@leops leops Awaiting requested review from leops

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ematipico @xunilrj @leops @yassere