-
Notifications
You must be signed in to change notification settings - Fork 664
Conversation
website/playground/src/types.ts
Outdated
export enum IndentStyle { Tab = "tab", Space = "space" } | ||
export enum SourceType { Module = "module", Script = "script" } | ||
export enum QuoteStyle { Double = "double", Single = "single" } | ||
export enum IndentStyle { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are too many unnecessary code changes. I will fix them a little later.
Before: Screencast.from.07-12-2022.12.30.39.PM.webm.movAfter: Screencast.from.07-12-2022.12.29.30.PM.webm.movIn the after video, you can see characters appearing as I type. The recording is stil choppy on my computer. You can test it either locally or on deployment to feel the difference. |
website/playground/package.json
Outdated
"format:rome": "rome format --write src ." | ||
}, | ||
"dependencies": { | ||
"@codemirror/lang-javascript": "^6.0.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I notice that you use lang-javascript
, does this package support jsx, tsx
syntax ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes.
Apparently firefox is the hold out here. It doesn't work in dev (Vite restriction) but works in production. vitejs/vite#4586 (comment) |
@ematipico Can you approve workflow so the CI can run? |
CI is failing, there's some code not formatted. Just run the command |
@ematipico Done |
Summary
Fixes #2856
react-codemirror
instead ofreact-textarea-code-editor
Test Plan