This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
fix(playground): bad type check #2865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
657ab34
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2dd7f43e.tools-8rn.pages.dev |
| Branch Preview URL: | https://fix-tsc-failure.tools-8rn.pages.dev |
ematipico
force-pushed
the
fix/tsc-failure
branch
from
b54956a
to
657ab34
Compare
xunilrj
approved these changes
Jul 12, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an error introduced by #2853
There was typescript error that I didn't see. This PR fixes it, and it also adds a command in the workflow to check the types of the project.
Test Plan
The CI should pass, exception for the false positive of the
noDeadCode