This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
ci: run the CLI on the VSCode extension and website codebase in the Rust PR workflow #2871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the Rust PR workflow
ematipico
changed the title
ematipico
approved these changes
Jul 13, 2022
xunilrj
approved these changes
Jul 13, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds an additional job to the
pull_requestworkflow that builds the CLI and tries to run it in CI mode over theeditors(VSCode extension) andwebsitedirectories. This step is "information only" and is marked ascontinue-on-errorto avoid causing the workflow to fail since those parts of the codebase are also tested using the latest release of the CLI in their corresponding workflow, and unreleased changes in the linter or formatter may lead to differences between the two set of warnings and errors being emitted.I also included a small fix in the LSP release workflow, the path to the version update script was out of sync with the actual file in the repo
Test Plan
Run the workflow and check that it works as expected