Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

fix(rome_js_analyze): no unused variables accepting ts public/private constructor parameters #3316

Merged
merged 5 commits into from
Oct 4, 2022

Conversation

xunilrj
Copy link
Contributor

@xunilrj xunilrj commented Oct 3, 2022

Summary

Closes #3183

Test Plan

> cargo test -p rome_js_analyze -- no_unused

@xunilrj xunilrj requested a review from leops as a code owner October 3, 2022 14:52
@xunilrj xunilrj temporarily deployed to netlify-playground October 3, 2022 14:52 Inactive
@netlify
Copy link

netlify bot commented Oct 3, 2022

Deploy Preview for rometools ready!

Name Link
🔨 Latest commit b9a8f1a
🔍 Latest deploy log https://app.netlify.com/sites/rometools/deploys/633b31a2d8e306000805d020
😎 Deploy Preview https://deploy-preview-3316--rometools.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Oct 3, 2022

@xunilrj xunilrj temporarily deployed to netlify-playground October 3, 2022 17:31 Inactive
@xunilrj xunilrj added this to the 0.10.0 milestone Oct 3, 2022
@xunilrj xunilrj temporarily deployed to netlify-playground October 3, 2022 18:02 Inactive
@xunilrj xunilrj temporarily deployed to netlify-playground October 3, 2022 18:37 Inactive
@xunilrj xunilrj force-pushed the fix/3183-public-private-constructor-parameter branch from 3359832 to b9a8f1a Compare October 3, 2022 19:01
@xunilrj xunilrj temporarily deployed to netlify-playground October 3, 2022 19:01 Inactive
@ematipico ematipico added the A-Linter Area: linter label Oct 4, 2022
@ematipico ematipico merged commit 66ab560 into main Oct 4, 2022
@ematipico ematipico deleted the fix/3183-public-private-constructor-parameter branch October 4, 2022 07:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Linter Area: linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 When using private fieldName in constructor, rome says js/noUnusedVariables
2 participants