fix(rome_js_analyze): useValidAnchor considering all possible expressions #3599
Conversation
✅ Deploy Preview for docs-rometools canceled.
|
|
Comparing fix(rome_js_analyze): useValidAnchor considering all possible expressions Snapshot #6 to median since last deploy of rome.tools.
1 page tested
|
| Chrome Desktop | iPhone, 4G LTE | Motorola Moto G Power, 3G connection |
|---|---|---|
 |
 |
 |
Most significant changes
 |
Value | Budget |
|---|---|---|
| JS Parse & Compile iPhone, 4G LTE |
470ms  from 10ms |
 |
| Largest Contentful Paint Motorola Moto G Power, 3G connection |
16.5s  from 506ms |
|
| First Contentful Paint Motorola Moto G Power, 3G connection |
16.5s from 506ms |
|
| Total Blocking Time Motorola Moto G Power, 3G connection |
238ms  from 12ms |
|
| Total JavaScript Size in Bytes Chrome Desktop |
5.27 MB  from 309 KB |
|
28 other significant changes: Total JavaScript Size in Bytes on iPhone, 4G LTE, Total JavaScript Size in Bytes on Motorola Moto G Power, 3G connection, JS Parse & Compile on Motorola Moto G Power, 3G connection, First Contentful Paint on Chrome Desktop, Largest Contentful Paint on Chrome Desktop, JS Parse & Compile on Chrome Desktop, Speed Index on Motorola Moto G Power, 3G connection, First Contentful Paint on iPhone, 4G LTE, Largest Contentful Paint on iPhone, 4G LTE, Number of Requests on Chrome Desktop, Number of Requests on iPhone, 4G LTE, Number of Requests on Motorola Moto G Power, 3G connection, Total Page Size in Bytes on Chrome Desktop, Total Page Size in Bytes on iPhone, 4G LTE, Total Page Size in Bytes on Motorola Moto G Power, 3G connection, Time to Interactive on Chrome Desktop, Total Blocking Time on Chrome Desktop, Time to Interactive on Motorola Moto G Power, 3G connection, Time to Interactive on iPhone, 4G LTE, Speed Index on Chrome Desktop, Total HTML Size in Bytes on Chrome Desktop, Total HTML Size in Bytes on iPhone, 4G LTE, Total HTML Size in Bytes on Motorola Moto G Power, 3G connection, Total Image Size in Bytes on Chrome Desktop, Total Image Size in Bytes on iPhone, 4G LTE, Total Image Size in Bytes on Motorola Moto G Power, 3G connection, Lighthouse Performance Score on Motorola Moto G Power, 3G connection, Lighthouse Performance Score on Chrome Desktop
Calibre: Site dashboard | View this PR | Edit settings | View documentation
| | JsAnyExpression::JsSuperExpression(_) | ||
| | JsAnyExpression::JsUnaryExpression(_) | ||
| | JsAnyExpression::JsUnknownExpression(_) | ||
| | JsAnyExpression::JsYieldExpression(_) |
There was a problem hiding this comment.
It would certainly be a very awkward way to write a component, but technically a yield expression may return a valid string value for href
There was a problem hiding this comment.
In my view, we should either both list JsAwaitExpression and JsYieldExpression or neither of them. Because both can yield a valid URL but only if the framework supports async execution when rendering.
| | JsAnyExpression::JsSuperExpression(_) | ||
| | JsAnyExpression::JsUnaryExpression(_) | ||
| | JsAnyExpression::JsUnknownExpression(_) | ||
| | JsAnyExpression::JsYieldExpression(_) |
There was a problem hiding this comment.
In my view, we should either both list JsAwaitExpression and JsYieldExpression or neither of them. Because both can yield a valid URL but only if the framework supports async execution when rendering.
xunilrj
deleted the
fix/useValidAnchor-not-considering-all-expressions
branch
* upstream/main: fix(npm/js-api): Import type from @rometools/backend-jsonrpc (rome#3647) doc(npm/js-api): Add experimental warning to README fix(npm/js-api): Lazy load backend implementations (rome#3652) feat(rome_lsp): stop the daemon after the last client disconnects (rome#3643) fix(npm/js_api): Ensure JS API build contains `dist` folder (rome#3648) fix(rome_cli): ensures the service only connects to compatible versions (rome#3642) feat(playground): add settings button and group IR (rome#3559) release: v10.0.1 (rome#3649) fix(rome_js_analyze): False positives for interactive elements in `useKeyWithClickEvents` (rome#3644) fix(rome_js_semantic): support for object and array bindings when exporting (rome#3620) doc(editors): Clarify Rome discovery (rome#3639) fix(rome_js_analyze): improve the detection of `ReactDOM.render` calls in `noRenderReturnValue` (rome#3626) chore(npm): add license (rome#3629) Add rustdocs index Add environment Change rust docs to use Netlify fix(rome_js_analyze): useValidAnchor considering all possible expressions (rome#3599) fix(rome_js_formatter): Trailing comma inside import rome#3600 (rome#3624)
Summary
Closes #3590.
We need to accept every expression that can potentially return a string.
Test Plan