This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
fix(rome_js_formatter): abstract must precede accessor #4242
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
While I was updating prettier snapshots in #4234,
cargo test
failed on a mis-formatted code.The following code:
was formatted at the following syntactically invalid code:
This PR fixes this issue.
In the future, code could be refactored in order to use the enum that encodes modifier precedence in the parser.
Note: By the way, I am not sure to understand why the formatter tries to fix the modifier order if the parser errors as soon as a mis-ordered modifier is found.
Test Plan
I included a test for the formatter.
Documentation
No change.