This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
Install correct binstall crate #4635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-rometools canceled.Built without sensitive environment variables
|
|
Thank you for catching that! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I just ran
just install-toolsas theCONTRIBUTING.mdguide told me to, but it didn't work for me, because it appears to install the wrongbinstallcrate. The one it installed was this unmaintained crate: https://crates.io/crates/binstall, but the one it should install (to makecargo binstallwork) is this one: https://crates.io/crates/cargo-binstallTest Plan
If you want to reproduce it, make sure no
binstallcrate is installed:cargo uninstall binstall cargo uninstall cargo-binstall cargo binstall # This should error now.Then you can rerun
just install-tools, and with this PR it should install the correct one.