Skip to content
This repository has been archived by the owner on Aug 31, 2023. It is now read-only.

ci: avoid installing cargo-cache twice #4648

Merged
merged 2 commits into from
Jul 2, 2023

Conversation

TaKO8Ki
Copy link
Contributor

@TaKO8Ki TaKO8Ki commented Jul 2, 2023

Summary

We don't need to install cargo-cache when cleaning the cache because moonrepo/setup-rust action already done it in advance.

I've already checked it in other pull request on my fork. A Documentation job failed, but this is not related to changes in this pull request. The reason is that my fork doesn't have an appropriate GitHub token.

TaKO8Ki#1

Test Plan

CI should pass.

@netlify
Copy link

netlify bot commented Jul 2, 2023

Deploy Preview for docs-rometools canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 1848f6b
🔍 Latest deploy log https://app.netlify.com/sites/docs-rometools/deploys/64a1b260bd58830008bb7199

@TaKO8Ki TaKO8Ki force-pushed the avoid-installing-cargo-cache branch from 14cd789 to 1848f6b Compare July 2, 2023 17:22
@Conaclos Conaclos self-requested a review July 2, 2023 17:27
@Conaclos Conaclos merged commit e18ebe6 into rome:main Jul 2, 2023
5 checks passed
@Conaclos
Copy link
Contributor

Conaclos commented Jul 2, 2023

Thanks :)

@TaKO8Ki TaKO8Ki deleted the avoid-installing-cargo-cache branch July 2, 2023 17:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants