This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
refactor(rome_js_analyze): handle globalThis for noNewSymbol
#4707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-rometools ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
github-actions
bot
added
A-Linter
ematipico
approved these changes
Jul 18, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves
noNewSymbolby handlingglobalThisandwindowglobal namespaces.I also moved the rule to the correct location (
analyzerstosemantic_analyzers).I noted that other rules are in the wrong location.
I think we should merge
semantic_analyzersintoanalyzers. The separation seems confusing for most of the contributors...Test Plan
Test added.