Skip to content

Commit

Permalink
[PyROOT] Add back initializer list pythonization to CPyCppyy
Browse files Browse the repository at this point in the history
The patch that disables the initializer list pythonization should in
principle not be necessary.
  • Loading branch information
guitargeek committed Aug 29, 2024
1 parent 9efc2c8 commit 9c2ac30
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 36 deletions.
2 changes: 0 additions & 2 deletions bindings/pyroot/cppyy/CPyCppyy/src/Pythonize.cxx
Original file line number Diff line number Diff line change
Expand Up @@ -1721,7 +1721,6 @@ bool CPyCppyy::Pythonize(PyObject* pyclass, const std::string& name)
#endif

// This pythonization is disabled for ROOT because it is a bit buggy
#if 0
if (Cppyy::IsAggregate(((CPPClass*)pyclass)->fCppType) && name.compare(0, 5, "std::", 5) != 0) {
// create a pseudo-constructor to allow initializer-style object creation
Cppyy::TCppType_t kls = ((CPPClass*)pyclass)->fCppType;
Expand Down Expand Up @@ -1789,7 +1788,6 @@ bool CPyCppyy::Pythonize(PyObject* pyclass, const std::string& name)
}
}
}
#endif


//- class name based pythonization -------------------------------------------
Expand Down

This file was deleted.

1 change: 0 additions & 1 deletion bindings/pyroot/cppyy/sync-upstream
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ mv cppyy_CMakeLists.txt cppyy/CMakeLists.txt

# Apply patches (they were created with git format-patch -1 HEAD)
# Alternatively, one can also use "git am" to create individual commits
git apply patches/CPyCppyy-Disable-initializer-style-construction.patch
git apply patches/CPyCppyy-Adapt-to-no-std-in-ROOT.patch
git apply patches/CPyCppyy-Always-convert-returned-std-string.patch
git apply patches/CPyCppyy-Disable-implicit-conversion-to-smart-ptr.patch
Expand Down

0 comments on commit 9c2ac30

Please sign in to comment.