Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cling] Make parts of the cling codebase similar to upstream clang-repl #15374

Merged
merged 8 commits into from
May 6, 2024

Conversation

devajithvs
Copy link
Contributor

@devajithvs devajithvs commented Apr 29, 2024

This Pull request:

Makes non-breaking changes to the existing code to make cling similar to upstream clang-repl. The idea is to make more changes in a similar fashion and completely swap out certain functions when they are similar enough.

Changes or fixes:

Checklist:

  • tested changes locally
  • updated the docs (if necessary)

This PR fixes #

Copy link
Member

@vgvassilev vgvassilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking up this challenge. This is awesome!

@vgvassilev
Copy link
Member

@smuzaffar, we will probably start moving towards more upstream llvm parts in Cling. These PRs need to be tested on cmssw because of relocation and pcms. Can you test this PR?

Copy link

Test Results

    10 files      10 suites   2d 5h 48m 40s ⏱️
 2 631 tests  2 631 ✅ 0 💤 0 ❌
24 807 runs  24 807 ✅ 0 💤 0 ❌

Results for commit 244d744.

@smuzaffar
Copy link
Contributor

@smuzaffar, we will probably start moving towards more upstream llvm parts in Cling. These PRs need to be tested on cmssw because of relocation and pcms. Can you test this PR?

CMSSW tests started via cms-sw#206

@smuzaffar
Copy link
Contributor

@vgvassilev , cmssw tests looks good. A unit test failure is not related to this PR.

@vgvassilev
Copy link
Member

@smuzaffar, thank you!

ROOT CI / mac14 ARM64 LLVM_ENABLE_ASSERTIONS=On seems to be broken at cmake configuration and I do not see how this could be caused by this PR. Let's move forward here.

@devajithvs devajithvs merged commit 3cc1497 into root-project:master May 6, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants