-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cling] Make parts of the cling codebase similar to upstream clang-repl
#15374
Conversation
640e6cd
to
244d744
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking up this challenge. This is awesome!
@smuzaffar, we will probably start moving towards more upstream llvm parts in Cling. These PRs need to be tested on cmssw because of relocation and pcms. Can you test this PR? |
Test Results 10 files 10 suites 2d 5h 48m 40s ⏱️ Results for commit 244d744. |
CMSSW tests started via cms-sw#206 |
@vgvassilev , cmssw tests looks good. A unit test failure is not related to this PR. |
@smuzaffar, thank you!
|
This Pull request:
Makes non-breaking changes to the existing code to make cling similar to upstream clang-repl. The idea is to make more changes in a similar fashion and completely swap out certain functions when they are similar enough.
Changes or fixes:
Checklist:
This PR fixes #