Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webpack implementation improvements #1627

Merged
merged 4 commits into from
Mar 24, 2016
Merged

Conversation

ptrckvzn
Copy link

  • not using any environment variables in the npm scripts for better windows compatibility (removed SAGE_ENV)
  • extracted options to a config file
  • dist/ keep the same assets folder structure (images/, fonts/, styles/, scripts/) - this work better with the assets loaded via php as it expect subfolders to the dist folder
  • webpack.config has settings specific to the "watch" script
  • renamed the watch script to watch.js
  • add image-webpack-loader for optimization

@retlehs retlehs merged commit bf31b59 into roots:sage-9 Mar 24, 2016
@retlehs
Copy link
Sponsor Member

retlehs commented Mar 24, 2016

thank you for your continued efforts on this 💙

@ptrckvzn
Copy link
Author

No problem. Thank YOU guys for Sage/Trellis/Bedrock. :) I use those on every project I work on and I am currently working on a few ones using this sage branch, so I will keep improving as I go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants