Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove path.extname() check #1673

Merged
merged 1 commit into from
Jul 21, 2016
Merged

Remove path.extname() check #1673

merged 1 commit into from
Jul 21, 2016

Conversation

WatsonWeb
Copy link
Contributor

Remove path.extname() check to fix build:production task.

Currently path.extname() is being supplied an object when it expects a string, resulting in a fatal error during production builds.

Removal is the cleanest solution as it's an unnecessary check, assets[name] will always be an object.

Remove path.extname() check to fix build:production task.

Currently path.extname() is being supplied an object when it expects a string, resulting in a fatal error during production builds.

Removal is the cleanest solution as it's an unnecessary check, assets[name] will always be an object.
@retlehs retlehs merged commit 69917bf into roots:sage-9 Jul 21, 2016
@retlehs retlehs mentioned this pull request Jul 21, 2016
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants