Rework template wrapper, bring back template_part() #1678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings back the previous
sidebar_path()functionality, but I've re-implemented it as part of a more generictemplate_part()helper function. The helper function is aware of the main template and it will first check for partials appended with the main template name.So if you have...
And you load your sidebar with
App\template_part('partials/sidebar');Then when the front-page.php template is loaded, the sidebar-front-page.php partial will also be loaded.
Additionally, this PR alters some of the language to be a little more consistent with Sage 8. Instead of "wrap" and "unwrap," I'm using "layout" (e.g., base.php) and "main" (e.g., page.php) in the Template class.