Fix/Improve $(eval ...) #2269
Open
Fix/Improve $(eval ...) #2269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We just need to protect against symbols starting with double underscores. Having double underscores anywhere else isn't a problem.
|
Ping @jacobperron |
|
This would make writing list comprehension expressions in launch files much easier! Thanks for the PR. |
peci1
approved these changes
Apr 9, 2023
|
@mjcarroll @sloretz friendly request for review. This PR is good to go according to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Evaluation of global symbols in list comprehension context (e.g.
$(eval [arg(var) for var in ['fuga', 'arg']])) was failing:AttributeError: '_DictWrapper' object has no attribute 'get'Essentially, symbols need to be passed as the
globalsargument toeval()and this argument needs to inherit fromdict.Additionally, this PR improves the discarding of private symbols (starting with double underscore). Previously, any double underscores were considered offending, even those in the middle of a symbol or in literal text.
These are the same changes, I have implemented for
xacro.