The installed_pkgs.log file now covers dynamic builddeps #1431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
praiskup
force-pushed
the
praiskup-postdeps-hook
branch
from
5163a66
to
ead7b16
Compare
This change required us to create a new "postdeps" hook with post-%generate_buildrequires timing. Fixes: rpm-software-management#1429 Relates: rpm-software-management#1393
praiskup
force-pushed
the
praiskup-postdeps-hook
branch
from
ead7b16
to
4ffac55
Compare
xsuchy
reviewed
Aug 23, 2024
| @@ -43,7 +43,7 @@ def __init__(self, plugins, conf, buildroot): | |||
| self.inst_done = False | |||
| self.online = self.buildroot.config['online'] | |||
| plugins.add_hook("postyum", self._availablePostYumHook) | |||
| plugins.add_hook("prebuild", self._installedPreBuildHook) | |||
There was a problem hiding this comment.
Although this hook is not documented, it is used by several plugins. I believe it should not be removed.
There was a problem hiding this comment.
The hooks in this "prebuild" namespace are still called, this particular hook is just moved to a later timing...
There was a problem hiding this comment.
Right. I was confused and thought you are replacing the hook itself. Sorry for the noise.
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change required us to create a new "postdeps" hook with post-%generate_buildrequires timing.
Fixes: #1429
Relates: #1393