Add tag category ordering feature #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neobooru
changed the title
neobooru
force-pushed
the
change_tag_category_order
branch
from
958a835
to
368372e
Compare
sgsunder
requested changes
Sep 21, 2020
sgsunder
approved these changes
Sep 24, 2020
|
Made a PR on your branch to fix the failing tests: neobooru#10 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How does this look?
This sorts by
order -> isDefault -> categoryName -> tagNameThis doesn't change the default behavior (sorted a-z and default tags last) because order = 1 by default.
Didn't write any tests for this yet, but seems to work fine in my test setup.