Default upload tags and anonymous uploads (improved) #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would incorrectly check the anonymous box when duplicates were found. po5@91b11c5 |
|
hi - are there still any plans to merge this? Having default tags when uploading would be a great addition. |
When similar posts were found, the anonymous upload checkbox for that image would become checked, because we treat anything !== undefined as 'checked', and in post_upload_views.js we set 'anonymous' to a querySelector, which returns null on failure and not undefined. Treat null as 'unchecked' to fix this issue, and prevent future mistakes slipping past.
Anonymous checkbox on images would not actually do anything, when the global checkbox was unchecked. The value of anonymous becomes a node, and it fails the anonymous === true check in save(). I don't understand why anonymous is treated differently from other post parameters and supplied as an argument to save(). Keeping it the way it is, I guess...
neobooru
force-pushed
the
feature-534
branch
from
71c4f0e
to
d120f00
Compare
|
Oh! This would be super handy, auto-set tags and safety level? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.