Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds a mechanism to wait for receipt so the user gets feedback #100

Merged
merged 1 commit into from
Mar 15, 2022
Merged

Adds a mechanism to wait for receipt so the user gets feedback #100

merged 1 commit into from
Mar 15, 2022

Conversation

aguschirico
Copy link
Contributor

…ion.

Title of pull request

Adds the await for the transaction receipt so the user gets feedback about the swap transaction.

Description

  • Makes use of the waitForReceipt function in utils.js

How to Test

  • Config your .env file
  • run yarn install
  • run with yarn serve

Case 1

  1. Run the server

  2. Claim for a transaction that crosses WBTC onto rKovWBTC or rBWBTC and use the "Convert to rBTC" option
    image

Expected Result

  • The page keeps blocked until the mined transaction receipt is found

pmprete
pmprete approved these changes Mar 15, 2022
View reviewed changes
Copy link
Contributor

@pmprete pmprete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pmprete pmprete merged commit 426377d into main Mar 15, 2022
@aguschirico aguschirico deleted the TBRE-399-add-all-necesary-checks-in-the-ui branch March 24, 2022 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmprete pmprete pmprete approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aguschirico @pmprete @augustoIOV