Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup unit/e2e tests #110

Merged
merged 3 commits into from
Mar 24, 2022
Merged

Setup unit/e2e tests #110

merged 3 commits into from
Mar 24, 2022

Conversation

aguschirico
Copy link
Contributor

Setup unit and e2e tests on the ui project

The features added by this PR:

  • Added vue-jest support via vue-cli
  • Added initial basic unit test case for CrossForm as an example
  • Add coverage collection by default on unit tests
  • Added cypress setup for e2e tests via vue-cli
  • Added initial basic e2e test for checking the "connect wallet" button is displayed when the app starts
  • Fix several code-linter errors/styling issues
    image

How to Test

run yarn test:unit for running the unit tests
run yarn test:e2e for running cypress e2e tests

@aguschirico aguschirico requested review from a team, poldo-iov, joaoiovlabs, gsoares85 and pmprete and removed request for a team March 24, 2022 11:07
pmprete
pmprete approved these changes Mar 24, 2022
View reviewed changes
Copy link
Contributor

@pmprete pmprete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! I recommend when running the linter to push that in a different PR, as it makes a lot of changes and the actual changes are hard to track.

@aguschirico aguschirico merged commit 120da7c into main Mar 24, 2022
@aguschirico aguschirico deleted the tests_setup branch March 24, 2022 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmprete pmprete pmprete approved these changes

@poldo-iov poldo-iov Awaiting requested review from poldo-iov poldo-iov was automatically assigned from rsksmart/gateways

@joaoiovlabs joaoiovlabs Awaiting requested review from joaoiovlabs joaoiovlabs was automatically assigned from rsksmart/gateways

@gsoares85 gsoares85 Awaiting requested review from gsoares85

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aguschirico @pmprete @augustoIOV