Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes all code related to NFT support. #120

Merged
merged 2 commits into from
Apr 20, 2022
Merged

Removes all code related to NFT support. #120

merged 2 commits into from
Apr 20, 2022

Conversation

aguschirico
Copy link
Contributor

Removes all code related to NFT support

This PR removes all code related to NFT support, as it's already a supported use case in multichain.org

Description

  • Remove all files related to either ERC721 or NFT
  • Remove formWrapper so it doesn't display the tabs anymore
  • Remove all code related to tokenTypes
  • Remove env var used to hide the NFT support features

How to Test

  • Config your .env file
  • Run the server

Case 1

  1. Run the server
$~ npm run serve

Checklist

  • [] Lint is clean npm run lint
  • [] Prettier is passing npm run prettier

pmprete
pmprete approved these changes Apr 20, 2022
View reviewed changes
Copy link
Contributor

@pmprete pmprete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@aguschirico aguschirico merged commit 37dc741 into main Apr 20, 2022
@aguschirico aguschirico deleted the TBRE-542-ui-remove-all-code-related-to-nft-support branch April 20, 2022 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsoares85 gsoares85 gsoares85 approved these changes

@pmprete pmprete pmprete approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aguschirico @gsoares85 @pmprete @augustoIOV