Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the slider #121

Merged
merged 3 commits into from
Apr 20, 2022
Merged

Remove the slider #121

merged 3 commits into from
Apr 20, 2022

Conversation

aguschirico
Copy link
Contributor

Remove the slider

Based on a recommendation from UX, we are getting rid of the slider in all the UIs we have (Wallet, new Swap UI not including one, etc).

Description

  • Remove the RangeInput component
  • Remove the code that uses the rangeInput
  • fix tiny issue with receiveAmount

How to Test

  • Config your .env file
  • Run the server

Case 1

  1. Run the server
$~ npm run serve
  1. Click on NFT

Expected Result

  • The nft green block should change

Case N...

Checklist

  • [] Lint is clean npm run lint
  • [] Prettier is passing npm run prettier

pmprete
pmprete approved these changes Apr 20, 2022
View reviewed changes
Copy link
Contributor

@pmprete pmprete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, i would rename the tittle to remove NFT to make it more clear

pmprete
pmprete approved these changes Apr 20, 2022
View reviewed changes
Copy link
Contributor

@pmprete pmprete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@aguschirico aguschirico merged commit 6c83d68 into main Apr 20, 2022
@aguschirico aguschirico deleted the TBRE-601-remove-the-slider branch April 20, 2022 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsoares85 gsoares85 gsoares85 approved these changes

@pmprete pmprete pmprete approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aguschirico @gsoares85 @pmprete @augustoIOV