Important details NFT #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| data.sideFeeNft = fee / sideConfig.feePercentageDivider | ||
| }) | ||
|
|
||
| const NFT_FIXED_CONFIRMATIONS_BLOCK = 3 // maybe we are going to define it into the nft bridge contract |
There was a problem hiding this comment.
I'd maybe add a Github issue / Jira ticket under 'technical debt' to not lose sight of this comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add component for Important details at NFT
Created other component to show information about the NFT we could use the same, but there would be a bunch of ternary things in the middle to check if it is NFT and change the text, So it was created a component almost exactly the same
Description
ImportantDetailstoImportantDetailsErc20ImportantDetailsErc721How to Test
.envfile for some config that hasnftBridgeset like rinkeby (4)Case 1
Expected Result