Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added support for manage multiple chains and allow connections … #58

Merged
merged 3 commits into from
Nov 2, 2021
Merged

feat: Added support for manage multiple chains and allow connections … #58

merged 3 commits into from
Nov 2, 2021

Conversation

jjhcuadrosIOV
Copy link
Contributor

Multi chain support

Added support for change on different chains

Description

  • Added new functions to recover the networks
  • Now the networks have an environment field to identify with which environment should work
  • Was added new env field VUE_APP_ENV to identify the environment and the networks that should use
  • Fixed errors on components that request some information on the first load
  • Removed some information component to display only when the wallet is connected

How to Test

  • Config your .env file
  • Run the server

Case 1

  1. Run the server
$~ npm run serve
  1. Connect your wallet on Rinkeby
  2. Change your wallet to Kovan

Expected Result

  • The network should change and the transactions table should display the transactions for your current network

Checklist

  • Lint is clean npm run lint
  • Prettier is passing npm run prettier

@jjhcuadrosIOV
feat: Added support for manage multiple chains and allow connections …
cead7b1 
…using metamask wallet

Signed-off-by: Jonathan Huamani <jonathan.huamani@iovlabs.org>
@jjhcuadrosIOV
feat: updated new environment variable
f7fbaa0 
Signed-off-by: Jonathan Huamani <jonathan.huamani@iovlabs.org>
pmprete
pmprete previously approved these changes Oct 22, 2021
View reviewed changes
Copy link
Contributor

@pmprete pmprete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, when we get the multichain working we should remove VUE_APP_MAIN_CHAIN_ID and VUE_APP_SIDE_CHAIN_ID env variables

@jjhcuadrosIOV
fix: fixed display wrong transactions on transaction table
5728278 
feat: added destinationChainId to identify the destination
feat: moved logic for host and side network to independent classes
feat: added logic to identify if exist most than one network config for host network
feat: Updated indexedDB version storage
feat: the migration from localstorage to indexedDB now save the destinationChainId
fix: fixed error on search transaction component, now display correctly the transaction
feat: new logo
feat: new prev step for connect wallet and choice the destination network

Signed-off-by: Jonathan Huamani <jonathan.huamani@iovlabs.org>
@jjhcuadrosIOV jjhcuadrosIOV changed the base branch from main to nftbridge October 29, 2021 04:25
pmprete
pmprete approved these changes Nov 2, 2021
View reviewed changes
Copy link
Contributor

@pmprete pmprete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pmprete pmprete merged commit 2fccb77 into nftbridge Nov 2, 2021
@pmprete pmprete deleted the feature/support-multi-networks branch November 10, 2021 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmprete pmprete pmprete approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jjhcuadrosIOV @pmprete