Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add snapshot test for #3519 #3520

Merged
merged 6 commits into from
Jan 12, 2023
Merged

Add snapshot test for #3519 #3520

merged 6 commits into from
Jan 12, 2023

Conversation

cpsievert
Copy link
Collaborator

@cpsievert cpsievert commented Oct 1, 2021

Adds an automated test to ensure #3519 has been fixed (which happened via rstudio/bslib#372 )

B
</a>
</li>
<li class="dropdown active">
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before the change in rstudio/bslib#372, this .dropdown container was missing the .active class

@cpsievert cpsievert merged commit eebcf70 into main Jan 12, 2023
@cpsievert cpsievert deleted the nav-menu-active-snapshot branch January 12, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant