Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport workspace-pr-integr][Workspace] Add a workspace client in workspace plugin (#6094) #308

Conversation

SuZhou-Joe
Copy link
Collaborator

  • feat: add comment

  • feat: update unit test

  • feat: add CHANGELOG

  • feat: optimize comment

  • feat: optimize comment

  • feat: optimize code

  • feat: optimize code


Description

Issues Resolved

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

…oject#6094)

* feat: add comment

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: update unit test

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: add CHANGELOG

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: optimize comment

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: optimize comment

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: optimize code

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: optimize code

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

---------

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
@codecov-commenter
Copy link

codecov-commenter commented Mar 22, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 55.84%. Comparing base (0f44eff) to head (b5694be).

Files Patch % Lines
...ade_saved_config/create_or_upgrade_saved_config.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                   Coverage Diff                    @@
##           workspace-pr-integr     #308       +/-   ##
========================================================
- Coverage                67.05%   55.84%   -11.21%     
========================================================
  Files                     3345     3057      -288     
  Lines                    65044    61052     -3992     
  Branches                 10505     9887      -618     
========================================================
- Hits                     43615    34096     -9519     
- Misses                   18849    24874     +6025     
+ Partials                  2580     2082      -498     
Flag Coverage Δ
Linux_ ?
_1 32.60% <66.66%> (-0.01%) ⬇️
_2 ?
_3 43.46% <0.00%> (+<0.01%) ⬆️
_4 35.15% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SuZhou-Joe SuZhou-Joe force-pushed the backport-6094-to-workspace-pr-integr branch from b5694be to 62c0b58 Compare March 24, 2024 14:57
@SuZhou-Joe SuZhou-Joe merged commit efe6254 into ruanyl:workspace-pr-integr Mar 25, 2024
80 of 89 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants