Rails/SkipsModelValidations is inconsistence with touch #12
Comments
|
I think it's confusing the shoulda-matcher |
eugeneius
added a commit
to eugeneius/rubocop-rails
that referenced
this issue
Apr 11, 2020
The `Rails/SkipsModelValidations` cop currently incorrectly registers an
offense for the `touch` method from Shoulda Matchers' associations DSL:
it { is_expected.to belong_to(:user).touch(true) }
Active Record's `touch` method accepts attribute names, so we can treat
`touch` calls that pass boolean literal arguments as false positives.
8 tasks
koic
added a commit
that referenced
this issue
Apr 12, 2020
[Fix #12] Allow passing boolean literals to touch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Rails/SkipsModelValidations cop doesn't complain about the following relation:
belongs_to :user, touch: truebut it does complain in its test (Avoid using touch because it skips validations.):
it { should belong_to(:user).touch(true) }Expected behavior
Complain in both cases or in any of them. I would say that it should also complain in the relation.
RuboCop version
Originally opened at rubocop/rubocop#4098
The text was updated successfully, but these errors were encountered: