Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RuboCop Rails supports Rails 4 or higher #74

Merged
merged 1 commit into from
Jun 17, 2019

Conversation

koic
Copy link
Member

@koic koic commented Jun 15, 2019

This PR drops Rails 3 support.

RuboCop core was supported Rails 4+.
https://github.com/rubocop-hq/rubocop/tree/v0.71.0#compatibility

The Rails cops support the following versions:

  • Rails 4.0+

It conforms to the expected behavior of RuboCop core originally.

And Rails is maintained at 4.2.Z or higher.

4 Severe Security Issues
For severe security issues all releases in the current major series, and
also the last major release series will receive patches and new
versions. The classification of the security issue is judged by the core
team.

Currently included series: 5.2.Z, 5.1.Z, 5.0.Z, 4.2.Z.

https://guides.rubyonrails.org/maintenance_policy.html

The following is the RuboCop Rails and Rails 4 use case.
#68


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

This PR drops Rails 3 support.

RuboCop core was supported Rails 4+.
https://github.com/rubocop-hq/rubocop/tree/v0.71.0#compatibility

> The Rails cops support the following versions:
>
> - Rails 4.0+

It conforms to the expected behavior of RuboCop core originally.

And Rails is maintained at 4.2.Z or higher.

> 4 Severe Security Issues
> For severe security issues all releases in the current major series, and
> also the last major release series will receive patches and new
> versions. The classification of the security issue is judged by the core
> team.
>
> Currently included series: 5.2.Z, 5.1.Z, 5.0.Z, 4.2.Z.

https://guides.rubyonrails.org/maintenance_policy.html

The following is the RuboCop Rails and Rails 4 use case.
rubocop#68
@koic koic force-pushed the rubocop_rails_supports_rails_4_or_higher branch from c2d6907 to 74eba93 Compare June 15, 2019 15:43
@koic koic merged commit a6a1a46 into rubocop:master Jun 17, 2019
@koic koic deleted the rubocop_rails_supports_rails_4_or_higher branch June 17, 2019 15:09
koic added a commit to koic/rubocop-rails that referenced this pull request Jun 22, 2019
Follow up rubocop#74.

RuboCop Rails doesn't support Rails 3 or lower.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants