Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helper to retrieve CRL URIs from a certificate #275

Merged
merged 2 commits into from
Oct 31, 2019

Conversation

bdewater
Copy link
Contributor

Similar to #260

According to RFC 5280 a distribution point can contain a lot of things, but in practice I'm seeing only fullName URIs (6).

@ioquatix
Copy link
Member

Do you think we should add an example showing how to use it/why to use it?

@bdewater
Copy link
Contributor Author

bdewater commented Oct 21, 2019

I guess https://github.com/ruby/openssl/blob/master/sample/crlstore.rb could be updated, but that one in itself isn't terribly clear either 😕

I was planning to use it myself in cedarcode/webauthn-ruby#208 where I currently have a more brittle and uglier regex match to get the URI.

@ioquatix
Copy link
Member

For the name of the module, what are your thoughts on the casing, should it be CRLDistributionPoints since CRL is an abbreviation?

@bdewater
Copy link
Contributor Author

Sounds good to me, updated.

@bdewater
Copy link
Contributor Author

bdewater commented Oct 22, 2019

Hum, one flaky test that failed (and I can't restart) but the rest is all green.

Edit: fixed with a rebase on top of #278

@ioquatix
Copy link
Member

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants