Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interrupt rescuing causes issues with debugger #581

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Interrupt rescuing causes issues with debugger #581

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e4bc4f
Change `rescue Exception` to limit rescuing critical ones
notEthan Jul 8, 2024
b33d4ed
Configure Rubocop against `rescue Exception`
notEthan Jul 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .rubocop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,3 +55,7 @@ Layout/CaseIndentation:
Layout/EndAlignment:
Enabled: true
EnforcedStyleAlignWith: variable

# Exceptions should be rescued with `AllExceptionsExceptOnesWeMustNotRescue`
Lint/RescueException:
Enabled: true
12 changes: 11 additions & 1 deletion lib/rake.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,17 @@
# IN THE SOFTWARE.
#++

module Rake; end
module Rake
module AllExceptionsExceptOnesWeMustNotRescue
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't sure where would be a good place for this, just put it here for a draft PR.

# These exceptions are dangerous to rescue as rescuing them
# would interfere with things we should not interfere with.
AVOID_RESCUING = [NoMemoryError, SignalException, Interrupt, SystemExit]

def self.===(exception)
AVOID_RESCUING.none? { |ar| ar === exception }
end
end
end

require_relative "rake/version"

Expand Down
2 changes: 1 addition & 1 deletion lib/rake/application.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ def standard_exception_handling # :nodoc:
rescue OptionParser::InvalidOption => ex
$stderr.puts ex.message
exit(false)
rescue Exception => ex
rescue AllExceptionsExceptOnesWeMustNotRescue => ex
# Exit with error message
display_error_message(ex)
exit_because_of_exception(ex)
Expand Down
2 changes: 1 addition & 1 deletion lib/rake/promise.rb