Merge pull request #659 from kachick/accurate-some-io-attr_setters

Correct IO#{close_on_exec=, autoclose=, sync=} signatures

core/io.rbs

@@ -181,7 +181,7 @@ class IO < Object
   #     # ...
   #     f.gets # won't cause Errno::EBADF
   #
-  def autoclose=: (bool) -> bool
+  def autoclose=: (boolish) -> untyped
 
   # Returns `true` if the underlying file descriptor of *ios* will be closed
   # automatically at its finalization, otherwise `false`.
@@ -212,7 +212,7 @@ class IO < Object
   # just ignored since Ruby 2.3.
   def close: () -> NilClass
 
-  def close_on_exec=: (boolish) -> bool
+  def close_on_exec=: (boolish) -> untyped
 
   # Returns `true` if *ios* will be closed on exec.
   #
@@ -656,7 +656,7 @@ class IO < Object
   # ```
   def sync: () -> bool
 
-  def sync=: (boolish) -> bool
+  def sync=: (boolish) -> untyped
 
   def sysread: (Integer maxlen, String outbuf) -> String
 

test/stdlib/IO_test.rb

@@ -130,6 +130,10 @@ def test_autoclose=
                        io, :autoclose=, true
       assert_send_type "(bool) -> bool",
                        io, :autoclose=, false
+      assert_send_type "(::Integer) -> ::Integer",
+                       io, :autoclose=, 42
+      assert_send_type "(nil) -> nil",
+                       io, :autoclose=, nil
     end
   end
 
@@ -180,4 +184,34 @@ def test_write
       end
     end
   end
+
+  def test_close_on_exec
+    IO.open(IO.sysopen(__FILE__)) do |io|
+      assert_send_type '() -> bool',
+                       io, :close_on_exec?
+      assert_send_type '(::Integer) -> untyped',
+                       io, :close_on_exec=, 42
+      assert_send_type '() -> bool',
+                       io, :close_on_exec?
+      assert_send_type '(nil) -> nil',
+                       io, :close_on_exec=, nil
+      assert_send_type '() -> bool',
+                       io, :close_on_exec?
+    end
+  end
+
+  def test_sync
+    IO.open(IO.sysopen(__FILE__)) do |io|
+      assert_send_type '() -> bool',
+                       io, :sync
+      assert_send_type '(::Integer) -> ::Integer',
+                       io, :sync=, 42
+      assert_send_type '() -> bool',
+                       io, :sync
+      assert_send_type '(nil) -> nil',
+                       io, :sync=, nil
+      assert_send_type '() -> bool',
+                       io, :sync
+    end
+  end
 end