Merge pull request #1100 from pocke/Add_frozen_string_literal__true

Add frozen_string_literal: true
ruby · Aug 29, 2022 · f0d0eb9 · f0d0eb9
2 parents 7d8175e + d03ab77
commit f0d0eb9
Show file tree

Hide file tree

Showing 76 changed files with 159 additions and 5 deletions.
diff --git a/.rubocop.yml b/.rubocop.yml
@@ -13,3 +13,8 @@ Lint/DuplicateMethods:
   Enabled: true
   Include:
     - 'test/**/*_test.rb'
+
+Style/FrozenStringLiteralComment:
+  Enabled: true
+  Include:
+    - 'lib/**/*.rb'
diff --git a/lib/rbs.rb b/lib/rbs.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "rbs/version"
 
 require "set"

diff --git a/lib/rbs/ancestor_graph.rb b/lib/rbs/ancestor_graph.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RBS
   class AncestorGraph
     InstanceNode = _ = Struct.new(:type_name, keyword_init: true)

diff --git a/lib/rbs/annotate.rb b/lib/rbs/annotate.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "rdoc"
 
 require "rbs/annotate/rdoc_annotator"

diff --git a/lib/rbs/annotate/annotations.rb b/lib/rbs/annotate/annotations.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RBS
   module Annotate
     class Annotations

diff --git a/lib/rbs/annotate/formatter.rb b/lib/rbs/annotate/formatter.rb
@@ -1,10 +1,12 @@
+# frozen_string_literal: true
+
 module RBS
   module Annotate
     class Formatter
       attr_reader :buffer
 
       def initialize()
-        @buffer = ""
+        @buffer = +""
         @pending_separator = nil
       end
 
@@ -14,7 +16,7 @@ def <<(s)
             s = self.class.translate(s) or raise
           end
 
-          s.rstrip!
+          s = s.rstrip
 
           unless s.empty?
             if ss = @pending_separator

diff --git a/lib/rbs/annotate/rdoc_annotator.rb b/lib/rbs/annotate/rdoc_annotator.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RBS
   module Annotate
     class RDocAnnotator

diff --git a/lib/rbs/annotate/rdoc_source.rb b/lib/rbs/annotate/rdoc_source.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RBS
   module Annotate
     class RDocSource

diff --git a/lib/rbs/ast/annotation.rb b/lib/rbs/ast/annotation.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RBS
   module AST
     class Annotation

diff --git a/lib/rbs/ast/comment.rb b/lib/rbs/ast/comment.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RBS
   module AST
     class Comment

diff --git a/lib/rbs/ast/declarations.rb b/lib/rbs/ast/declarations.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RBS
   module AST
     module Declarations

diff --git a/lib/rbs/ast/members.rb b/lib/rbs/ast/members.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RBS
   module AST
     module Members

diff --git a/lib/rbs/ast/type_param.rb b/lib/rbs/ast/type_param.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RBS
   module AST
     class TypeParam
@@ -106,7 +108,7 @@ def self.rename(params, new_names:)
       end
 
       def to_s
-        s = ""
+        s = +""
 
         if unchecked?
           s << "unchecked "

diff --git a/lib/rbs/buffer.rb b/lib/rbs/buffer.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RBS
   class Buffer
     attr_reader :name

diff --git a/lib/rbs/builtin_names.rb b/lib/rbs/builtin_names.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RBS
   module BuiltinNames
     class Name

diff --git a/lib/rbs/cli.rb b/lib/rbs/cli.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "open3"
 require "optparse"
 require "shellwords"

diff --git a/lib/rbs/collection.rb b/lib/rbs/collection.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'yaml'
 require 'bundler'
 

diff --git a/lib/rbs/collection/cleaner.rb b/lib/rbs/collection/cleaner.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RBS
   module Collection
     class Cleaner

diff --git a/lib/rbs/collection/config.rb b/lib/rbs/collection/config.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RBS
   module Collection
 

diff --git a/lib/rbs/collection/config/lockfile_generator.rb b/lib/rbs/collection/config/lockfile_generator.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RBS
   module Collection
 

diff --git a/lib/rbs/collection/installer.rb b/lib/rbs/collection/installer.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RBS
   module Collection
     class Installer

diff --git a/lib/rbs/collection/sources.rb b/lib/rbs/collection/sources.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative './sources/base'
 require_relative './sources/git'
 require_relative './sources/stdlib'

diff --git a/lib/rbs/collection/sources/base.rb b/lib/rbs/collection/sources/base.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RBS
   module Collection
     module Sources

diff --git a/lib/rbs/collection/sources/git.rb b/lib/rbs/collection/sources/git.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'digest/sha2'
 require 'open3'
 require 'find'

diff --git a/lib/rbs/collection/sources/rubygems.rb b/lib/rbs/collection/sources/rubygems.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'singleton'
 
 module RBS

diff --git a/lib/rbs/collection/sources/stdlib.rb b/lib/rbs/collection/sources/stdlib.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'singleton'
 
 module RBS

diff --git a/lib/rbs/constant.rb b/lib/rbs/constant.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RBS
   class Constant
     attr_reader :name

diff --git a/lib/rbs/constant_table.rb b/lib/rbs/constant_table.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RBS
   class ConstantTable
     attr_reader :definition_builder

diff --git a/lib/rbs/definition.rb b/lib/rbs/definition.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RBS
   class Definition
     class Variable

diff --git a/lib/rbs/definition_builder.rb b/lib/rbs/definition_builder.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RBS
   class DefinitionBuilder
     attr_reader :env

diff --git a/lib/rbs/definition_builder/ancestor_builder.rb b/lib/rbs/definition_builder/ancestor_builder.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RBS
   class DefinitionBuilder
     class AncestorBuilder

diff --git a/lib/rbs/definition_builder/method_builder.rb b/lib/rbs/definition_builder/method_builder.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RBS
   class DefinitionBuilder
     class MethodBuilder

diff --git a/lib/rbs/environment.rb b/lib/rbs/environment.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RBS
   class Environment
     attr_reader :declarations

diff --git a/lib/rbs/environment_loader.rb b/lib/rbs/environment_loader.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RBS
   class EnvironmentLoader
     class UnknownLibraryError < StandardError

diff --git a/lib/rbs/environment_walker.rb b/lib/rbs/environment_walker.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RBS
   class EnvironmentWalker
     InstanceNode = _ = Struct.new(:type_name, keyword_init: true)

diff --git a/lib/rbs/errors.rb b/lib/rbs/errors.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RBS
   module MethodNameHelper
     def method_name_string()
@@ -216,7 +218,7 @@ def initialize(type:, method_name:, members:)
       @method_name = method_name
       @members = members
 
-      message = "#{Location.to_string location}: #{qualified_method_name} has duplicated definitions"
+      message = +"#{Location.to_string location}: #{qualified_method_name} has duplicated definitions"
       if members.size > 1
         message << " in #{other_locations.map { |loc| Location.to_string loc }.join(', ')}"
       end

diff --git a/lib/rbs/factory.rb b/lib/rbs/factory.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RBS
   class Factory
     def type_name(string)

diff --git a/lib/rbs/location_aux.rb b/lib/rbs/location_aux.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RBS
   class Location
     def inspect

diff --git a/lib/rbs/locator.rb b/lib/rbs/locator.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RBS
   class Locator
     attr_reader :decls

diff --git a/lib/rbs/method_type.rb b/lib/rbs/method_type.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RBS
   class MethodType
     attr_reader :type_params

diff --git a/lib/rbs/namespace.rb b/lib/rbs/namespace.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RBS
   class Namespace
     attr_reader :path

diff --git a/lib/rbs/parser_aux.rb b/lib/rbs/parser_aux.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RBS
   class Parser
     def self.parse_type(source, line: 1, column: 0, variables: [])

diff --git a/lib/rbs/parser_compat/lexer_error.rb b/lib/rbs/parser_compat/lexer_error.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 RBS.print_warning {
   "RBS::Parser::LexerError is deprecated and will be deleted in RBS 2.0."
 }

diff --git a/lib/rbs/parser_compat/located_value.rb b/lib/rbs/parser_compat/located_value.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 RBS.print_warning {
   "RBS::Parser::LocatedValue is deprecated and will be deleted in RBS 2.0."
 }

diff --git a/lib/rbs/parser_compat/semantics_error.rb b/lib/rbs/parser_compat/semantics_error.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 RBS.print_warning {
   "RBS::Parser::SemanticsError is deprecated and will be deleted in RBS 2.0."
 }

diff --git a/lib/rbs/parser_compat/syntax_error.rb b/lib/rbs/parser_compat/syntax_error.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 RBS.print_warning {
   "RBS::Parser::SyntaxError is deprecated and will be deleted in RBS 2.0."
 }

diff --git a/lib/rbs/prototype/helpers.rb b/lib/rbs/prototype/helpers.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RBS
   module Prototype
     module Helpers

diff --git a/lib/rbs/prototype/rb.rb b/lib/rbs/prototype/rb.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RBS
   module Prototype
     class RB

diff --git a/lib/rbs/prototype/rbi.rb b/lib/rbs/prototype/rbi.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RBS
   module Prototype
     class RBI

diff --git a/lib/rbs/prototype/runtime.rb b/lib/rbs/prototype/runtime.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RBS
   module Prototype
     class Runtime

diff --git a/lib/rbs/repository.rb b/lib/rbs/repository.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RBS
   class Repository
     DEFAULT_STDLIB_ROOT = Pathname(_ = __dir__) + "../../stdlib"

diff --git a/lib/rbs/resolver/constant_resolver.rb b/lib/rbs/resolver/constant_resolver.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RBS
   module Resolver
     class ConstantResolver

diff --git a/lib/rbs/resolver/type_name_resolver.rb b/lib/rbs/resolver/type_name_resolver.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RBS
   module Resolver
     class TypeNameResolver

diff --git a/lib/rbs/sorter.rb b/lib/rbs/sorter.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RBS
   class Sorter
     include RBS::AST

diff --git a/lib/rbs/substitution.rb b/lib/rbs/substitution.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RBS
   class Substitution
     attr_reader :mapping

diff --git a/lib/rbs/test.rb b/lib/rbs/test.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "securerandom"
 require "rbs/test/observer"
 require "rbs/test/spy"

diff --git a/lib/rbs/test/errors.rb b/lib/rbs/test/errors.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RBS
   module Test
     module Errors

diff --git a/lib/rbs/test/hook.rb b/lib/rbs/test/hook.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "rbs"
 require "pp"
 

diff --git a/lib/rbs/test/observer.rb b/lib/rbs/test/observer.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RBS
   module Test
     module Observer

diff --git a/lib/rbs/test/setup.rb b/lib/rbs/test/setup.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "rbs"
 require "rbs/test"
 require "optparse"