Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use manifest.yaml instead of manually for validate task #1010

Merged
merged 2 commits into from
Jun 20, 2022
Merged

Use manifest.yaml instead of manually for validate task #1010

merged 2 commits into from
Jun 20, 2022

Conversation

ksss
Copy link
Collaborator

@ksss ksss commented May 29, 2022

and add missing dependency for stdlib/cgi.

@ksss ksss changed the title Use manifest.yaml instead of manually Use manifest.yaml instead of manually for validate task May 29, 2022
@pocke pocke self-requested a review May 31, 2022 07:05
soutaro
soutaro approved these changes Jun 20, 2022
View reviewed changes
Copy link
Member

@soutaro soutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement! 🙏

@soutaro soutaro merged commit 7350567 into ruby:master Jun 20, 2022
@soutaro soutaro mentioned this pull request Jun 20, 2022
Merged
@ksss ksss deleted the validate-auto-dep branch June 21, 2022 01:44
ksss added a commit to ksss/rbs that referenced this pull request Jun 21, 2022
@ksss
Revert "Add dependency lib"
961c06e 
This reverts commit 24411e2.
since ruby#1010
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soutaro soutaro soutaro approved these changes

@pocke pocke Awaiting requested review from pocke

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ksss @soutaro