Lean to the optional side #1021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soutaro
approved these changes
Jun 7, 2022
pocke
approved these changes
Jun 7, 2022
There was a problem hiding this comment.
LGTM!
Previously I tried to make the same change, but I didn't merge it. Because it introduces false negatives. The user cannot notice a missing block for a generated method.
But now I agree with optional blocks because the benefit is important even if there is a trade-off.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
gem_rbs_collection, I think there are a few fixes coming so far that will make the blocks optional.ruby/gem_rbs_collection#88
ruby/gem_rbs_collection#132
ruby/gem_rbs_collection#135
ruby/gem_rbs_collection#136
ruby/gem_rbs_collection#138
ruby/gem_rbs_collection#165
The cause is due to prototype output.
I feel it is not practical to make the block required.
I suggest leaning towards the optional side and relaxing the requirement.