Fix: Fix Kernel?.fail signature doesn't have cause #1026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pocke
reviewed
Jun 14, 2022
| @@ -871,8 +871,8 @@ module Kernel : BasicObject | |||
| # raise ArgumentError, "No parameters", caller | |||
| # | |||
| def self?.fail: () -> bot | |||
| | (String arg0) -> bot | |||
| | (_Exception arg0, ?untyped arg1, ?::Array[String] arg2) -> bot | |||
| | (String arg0, ?cause: Exception?) -> bot | |||
There was a problem hiding this comment.
[Goodcheck] Stop using parameter names like
arg0orarg1(view)The parameter names like
arg0orarg1is not informative enough.
Try finding good parameter names from documents or arglists.
If you cannot find a good name, just delete the name of the parameters.
Rule rbs.no_argYou can close this issue if no need to fix it. Learn more.
Sider suggests two comments for arg0, but it is not related to your change. So I'll close the suggestions and merge your PR.
I'll fix the Sider suggestions in another PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.