Move ENVClass definition under RBS::Unnamed
#1041
Conversation
run the following and rename ARGF.class to ARGFClass bundle exec rbs prototype runtime ARGF.class > core/argf.rbs
bundle exec rbs annotate core/argf.rbs
run the following and rename ARGFClass to ARGF or ARGF.class: bundle exec rake generate:stdlib_test[ARGFClass]
Starting with ruby v3.0, Random::Base was created to facilitate algorithm changes, and the inheritance relationship was changed. ref: ruby/ruby#3024
core/random.rbs
Outdated
| class Random < Object | ||
| include Random::Formatter | ||
| class Random < RBS::Unnamed::Random_Base | ||
| Base: singleton(RBS::Unnamed::Random_Base) |
There was a problem hiding this comment.
Are there plans to make Random::Base inheritable?
class Sample < Random::Base
endI know it is not a priority since there are few examples of its use, but it would be better if it were considered.
There was a problem hiding this comment.
Hmm, good point.
Currently defining Random::Base as a class would be the solution?
class Random::Base < RBS::Unnamed::Random_Base
endBut, it's not straightforward...
There was a problem hiding this comment.
Hmm... Cycle still exists with Random_Base and Random::Formatter.
There was a problem hiding this comment.
Because Random::Formatter is a module, not class, we cannot inherit a module.
There was a problem hiding this comment.
So, I would give up for this. We would take one of the two:
- Ignore
Random::Basefor now - Define the module and class as a constant
Neither allows using the classes/module from RBS. (This should be a good motivating example for adding a feature to define alias of classes/modules.)
There was a problem hiding this comment.
We can include the Unnamed::Random_Formatter module. 💡
There was a problem hiding this comment.
I don't see this as much of a problem in RBS, since superclasses can be omitted during open class.
Thanks for your consideration!
It cannot be defined directly in RBS. `Random` inherits `Random::Base`, and `Random::Base` is defined inside `Random`, which results in a circular dependency. Extracting the class and `Random::Formatter` module to `RBS::Unnamed` solves the problem. * `Random::Base` inherits `Random_Base` so that inheriting `Random::Base` works in RBS * `Random::Formatter` includes `Random_Formatter` so that including `Random::Formatter` works in RBS
soutaro
force-pushed
the
move-unnamed-classes
branch
from
e73e326
to
79511b9
Compare
soutaro
force-pushed
the
move-unnamed-classes
branch
from
79511b9
to
83b5228
Compare
Some Ruby objects like
ENVdoesn't have corresponding class exposed to user scripts. However, defining such a class is not allowed in RBS.We introduce
RBS::Unnamedpseudo module to define classes of those objects. Note that there are no objects defined corresponding to the classes.