Fix lexer to analyze escape characters #1043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Make it more explicit in `lexer.re` * Unescape `\\` too in unescape.c
soutaro
commented
Jun 22, 2022
| @@ -94,8 +94,8 @@ start: | |||
| "untyped" { return next_token(state, kUNTYPED); } | |||
| "void" { return next_token(state, kVOID); } | |||
|
|
|||
| dqstring = ["] ("\\"["] | [^"\x00])* ["]; | |||
| sqstring = ['] ("\\"['] | [^'\x00])* [']; | |||
| dqstring = ["] ("\\"[abefnrstv"\\] | [^"\\\x00])* ["]; | |||
There was a problem hiding this comment.
Explained in #996 (comment)
soutaro
commented
Jun 22, 2022
| @@ -30,6 +30,7 @@ void rbs_unescape_string(VALUE string) { | |||
| rb_hash_aset(HASH, rb_str_new_literal("\\t"), rb_str_new_literal("\t")); | |||
| rb_hash_aset(HASH, rb_str_new_literal("\\v"), rb_str_new_literal("\v")); | |||
| rb_hash_aset(HASH, rb_str_new_literal("\\\""), rb_str_new_literal("\"")); | |||
| rb_hash_aset(HASH, rb_str_new_literal("\\\\"), rb_str_new_literal("\\")); | |||
There was a problem hiding this comment.
We have to unescape two backslashes too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lexer.re\\too in unescape.cCloses #996