Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add overloads for math operation with rhs being BigDecimal #1053

Merged
merged 2 commits into from
Jul 14, 2022
Merged

Add overloads for math operation with rhs being BigDecimal #1053

merged 2 commits into from
Jul 14, 2022

Conversation

piotaixr
Copy link
Contributor

@piotaixr piotaixr commented Jul 1, 2022

Closes #1052

@pocke
Copy link
Member

pocke commented Jul 12, 2022

Could you avoid mixing cosmetic changes? It makes reviewing a bit harder, and the changed format in .rbs files is a different style from other .rbs files in this repository. So could you revert the cosmetic changes and only leave the core changes?

@piotaixr
Copy link
Contributor Author

Oh! Of course. Sorry. Will update the PR ASAP.
Asking rubymine to format becomes muscle memory at this point :-)

@piotaixr piotaixr force-pushed the feature/bigdecimal-operations branch from 8020658 to 51da34f Compare July 12, 2022 11:08
@piotaixr
Copy link
Contributor Author

Updated!

pocke
pocke approved these changes Jul 14, 2022
View reviewed changes
Copy link
Member

@pocke pocke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pocke pocke merged commit 3d32cfb into ruby:master Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pocke pocke pocke approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mathematical operations don't play well with BigDecimal
2 participants
@piotaixr @pocke