Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Warning.#warn and Kernel.#warn signatures #1056

Merged
merged 3 commits into from
Jul 12, 2022
Merged

Fix Warning.#warn and Kernel.#warn signatures #1056

merged 3 commits into from
Jul 12, 2022

Conversation

kachick
Copy link
Member

@kachick kachick commented Jul 3, 2022

Since Ruby 3.0, Warning and Kernel.#warn can take optional category.
And current RBS Warning.#warn is defined only on instance. This PR aims to fix both.

Referenced followings

Warning.#warn accept only 1 String for message
Category names
deprecated | experimental | nil
Can't define different signatures in different RUBY_VERSIONS

@pocke pocke merged commit af61480 into ruby:master Jul 12, 2022
@kachick
Copy link
Member Author

kachick commented Jul 12, 2022

Thank you!

@kachick kachick deleted the warn branch July 12, 2022 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants