Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add signature for RubyVM::AbstractSyntaxTree #1189

Merged
merged 7 commits into from
Feb 14, 2023
Merged

Add signature for RubyVM::AbstractSyntaxTree #1189

merged 7 commits into from
Feb 14, 2023

Conversation

ksss
Copy link
Collaborator

@ksss ksss commented Dec 26, 2022

Added method types for RubyVM::AbstractSyntaxTree and RubyVM::AbstractSyntaxTree::Node.

RubyVM::AbstractSyntaxTree` itself is marked as experimental, but we believe that there are a certain number of uses, including rbs.

However, The following methods marked as internal use have not been added.

  • RubyVM::AbstractSyntaxTree::Node#node_id
  • RubyVM::AbstractSyntaxTree::Node#script_lines
  • RubyVM::AbstractSyntaxTree::Node#source

The documentation is from ruby v3.1, but the types are based on ruby v3.2 code.

Copy link
Member

@soutaro soutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 🎉 🎉

@soutaro
Copy link
Member

soutaro commented Feb 13, 2023

Added a commit to make the tests pass.

That assumes unexpected working directory after `chdir` tests.
@soutaro soutaro merged commit cd46c1e into ruby:master Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants