Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install RBS for indirect dependency #1228

Merged
merged 1 commit into from
Feb 10, 2023
Merged

Install RBS for indirect dependency #1228

merged 1 commit into from
Feb 10, 2023

Conversation

soutaro
Copy link
Member

@soutaro soutaro commented Feb 9, 2023

Assume we have gem "parser" in the Gemfile, but we only have RBS of its depdendency ast, not parser itself. In this case rbs collection should have RBS of ast, but it didn't.

This PR installs the RBS of the dependency gem, even if the dependency source doesn't install.

@soutaro soutaro merged commit 1a8f7aa into master Feb 10, 2023
@soutaro soutaro deleted the indirect-dependency branch February 10, 2023 02:01
@soutaro soutaro added this to the RBS 3.0 milestone Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pocke pocke pocke approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
RBS 3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@soutaro @pocke